Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Sign In with Facebook Sign In with Google Sign In with OpenID Sign In with Twitter
Sign In Apply for Membership

Categories

In this Discussion

Who's Online 21

CurtisOdenSpencerMcericgillettejefftunnmcu_hqx00 +15 guests

Signature

garymardellgarymardell
in Questions
This discussion is related to the Signature addon.
Signature

Comments

  • GumCloudGumCloud
    Posts: 12
    Works fine! Thank you!
  • oinkfuoinkfu
    Posts: 40
    Hmm works fine up until it needs to be displayed on the posts, then you get an error (latest version of V2, rc1)...
  • garymardellgarymardell
    Posts: 819
    @oinkfu I will try and fix for the RC now, as its been released now :)
  • becoolbecool
    Posts: 39
    @garymardell Have you got around to fixing this yet?

    Thanks
  • lucluc
    Posts: 1,015
    Not sure if it's really worth fixing. Since RC1 was released, many many commits were done.
  • garymardellgarymardell
    Posts: 819
    @becool It should now work.

    @luc It wasn't too bad to fix, although i think before all the comments included the post itself counted as comments, now the post is a discussion. So i have to get the signature in both models.
  • becoolbecool
    Posts: 39
    Thanks!
  • garymardellgarymardell
    Posts: 819
    @becool There is one more thing sorry, you will need to update to address a security concern. The output of a signature is now formatted with the htmlpurifier to prevent malicious javascript in signature for example. I urge you to upgrade or change line 36 of defaul.php to

    <?php echo Gdn_Format::Html($Comment->Signature); ?>
  • becoolbecool
    Posts: 39
    thanks will do!
Sign In or Register to comment.