FileUpload 1.1 Released

Tim

This discussion is related to the FileUpload addon.

This plugin enables file uploads (as attachments) to discussions, comments and conversations. Multiple files can be uploaded simultaneously using AJAX.

If your server is configured properly, a realtime upload progress bar will also be displayed.

Upcoming versions will allow file management from the dashboard, as well as an implementation of thumbnails.

Desmanthus

Wow just fantastic Tim!

Any chance in the future of this displaying images from V1 Attachments? I have a V1 forum with tons of images uploaded and displayed using attachments and can't really consider switching until the images can come with me.

Thanks for the great plugin!

Tim

That will be something for @Todd's importer to deal with.

Tim

Also bear in mind that when someone develops a plugin for Version X, and you upgrade to Version Y, it is still the plugin developer's responsibility to maintain that functionality... not ours.

I've seen a few comments that seem to imply that the community expects core support for plugin features when upgrading. While this would be nice, its not entirely feasible.

Lincoln

@Tim I'd throw another lightswitch rave, but I'm still smarting from how hard the last one got voted down. Nice work. :)

@Desmanthus We may create a separate plugin for importing files after a data import. Trying to bring files along with the data import would make it incredibly more complex and time-consuming to execute.

Lincoln

@Tim Is this on GitHub?

Tim

@Lincoln its in our private plugin repo. Talk to mark?
Thanks for the virtual rave :D

emennny81

Im running vanilla 2.0.3 and got an error on the requirements:

FATAL ERROR IN: PHP.Gdn_ErrorHandler();

"FileUpload is missing the following requirement(s): Vanilla 2.0.2."
LOCATION: /var/www/html/vanilla/library/core/functions.general.php
> 330: if (count($MissingRequirements) > 0) {
> 331: $Msg = sprintf("%s is missing the following requirement(s): %s.",
> 332: $ItemName,
> 333: implode(', ', $MissingRequirements));
>>> 334: throw new Gdn_UserException($Msg);
> 335: }
> 336: }
> 337: }
> 338: }
BACKTRACE:
[/var/www/html/vanilla/library/core/class.pluginmanager.php 462] PHP::CheckRequirements();
[/var/www/html/vanilla/applications/dashboard/controllers/class.settingscontroller.php 510] Gdn_PluginManager->TestPlugin();
[/var/www/html/vanilla/library/core/class.dispatcher.php 276] SettingsController->TestAddon();
[/var/www/html/vanilla/index.php 38] Gdn_Dispatcher->Dispatch();

Tim

Check your index.php file, right at the top. You should see something like:
define('APPLICATION_VERSION', '2.0.3');

Either way, 2.0.3 SUCKED, I suggest 2.0.6

Desmanthus

Thanks for the response @Tim.

As you know, attachments for V1 was pretty widely used and I think support for converting/importing attachments would encourage many V1 users to upgrade.

Since Vanilla2 is now developing it's own "official" file upload plugin, maybe it is something that could be included. If I upgrade without my members' attachments they will put my head on a stick. :)

Just my two cents. Thanks for all the great work and for the best forum software out there.

Also..When trying out this plugin i see an upload bar, but wait and nothing happens. The image I am trying to upload is about 100k.

Update: @Lincoln Whatever/whoever makes it happen is fine by me. Thx.

PS I'm just drooling to be able to upgrade to V2 my V1 forum. Members are going to LOVE it.

emennny81

yeap it does say that.

<?php<br />define('APPLICATION', 'Vanilla');
define('APPLICATION_VERSION','2.0.3');
/*

JeffDunne

We seem to be missing the table definition for gdn_media (or I am)

Tim

I might have left it out of the setup method, since this has been hosted on our .com service where those tables already exist. I'll fix it asap.

Tim

Actually just looking at it now, the plugin (if you enabled it via Vanilla and not though your config file) should have executed its Setup() method, which contains the table definition.

ithcy

i'm getting an unhandled JS exception in firefox when I try to attach files. This happens after the file is selected and the JSON POST request has been sent.

This is the exception showing in firebug:uncaught exception: Invalid JSON: {"MediaResponse":{"Status":"success","MediaID":"4","Filename":"file.jpg","Filesize":138495,"FormatFilesize":"135.2K","ProgressKey":""},"FormSaved":true,"DeliveryType":"VIEW","Data":"","StatusMessage":"","RedirectUrl":""}

This is the contents of the response: {"FormSaved":true,"DeliveryType":"VIEW","Data":"(-- i snipped the base64 here --)","StatusMessage":"","RedirectUrl":""}

The GDN_Media table was created correctly and my attachments are being inserted into that table correctly. But they do not show up with the comments.

Not sure what's going on. I do not have APC installed.

Tim

@ithcy We're drawing a blank here as far as figuring out what caused your problem. We'll need to dig deeper, and for that to happen I'd be much obliged if you'd provide the following:

- A copy of your fileupload.js file
- A list of your currently installed plugins
- Browser name and version
- OS name and version
- Vanilla version

Thankyou :)

Tim

You can send the file to my vanilla email address.

JeffDunne

Thanks for that @Tim (thanks for the plugin too, will make a lot of my users happy)

Not sure what happened the first time, but disabling and re-enabling fixed the problem.

Clearly something screwy on my server.

TiGR

Bugs:

- It does not work with Opera browser (says Uploading... and does nothing).
- When you edit post and click "Attach file", file upload form appears, but it also appears at the bottom form (2 of them) and that does not disappear after you finish editing (at least in Chrome browser).

ithcy

Hi Tim, thanks very much for looking.

After some more debugging I found the problem. This plugin is not compatible with the Greasemonkey addon for firefox. When I disable Greasemonkey I'm able to attach files.

However TiGR's second issue is valid and happens in Firefox as well. The issue appears to be that, when editing a post, you have multiple DIVs on the page with the same ID ('CurrentUploader'), and each of those divs is matched by the selector in fileupload.js line 12, so they each receive the html append on line 121.

these guys just need unique IDs.

Tim

Good catch. I'll fix'r

TiGR

Another thing is that it does not show images in browser, but downloads them istead (image extension was .JPG)

Dr_Amazing

On 2.0.3, file attachements aren't showing up in comments, discussions, or anything. It's not a browser issue; it doesn't work on either IE 8 or the latest version of Chrome. Any ideas?

mandarin

Great plugin! I'v discovered a couple of issues though.
1. It doesn't accept files of type JPEG
2. There seems to be an issue with PNG files. I can only recreate this error on a random basis. I add first a PNG file (with spaces in filename), then another file (JPG with/without spaces in filename). When I view the post in the discussion only the first file is shown under the attachments. Sometimes both files are listed, sometimes not.

Raize

@Dr_Amazing I think it's counter intuitive to be testing a brand new plugin on anything but the latest version of Vanilla (2.0.6).. it seems to be functioning flawlessly for me. @mandarin jpg and png both uploaded fine for me on 2.0.6 (it could also be a plugin conflict)

This is such an awesome plugin, thanks team.

tmilovan

I have attachments displayed only in the first post of the discussion, for other posts files are uploaded but are not shown in the messages.

TiGR

- there is no way to delete attachments.

nickhx

File upload does not work if the file being uploaded has an apostrophe (') in it.

theocas

On 2.0.3, file attachements aren't showing up in comments, discussions, or anything. It's not a browser issue; it doesn't work on either IE 8 or the latest version of Chrome. Any ideas?

I have the same issue. With Vanilla 2.0.6.

binhdo

I noticed there are no attachment settings for guests or visitors who are not logged in. Guests can always view the attachments.

docmars

Thanks for the great plugin!

However, I am unable to upload other file types like .docx. They seem to upload fine, but they aren't displaying on any of the posts.

I'm using Vanilla 2.0.6.