Issues with 2.0.18

This discussion is related to the Emoticons addon.

Hi, I just updated to 2.0.18 and the latest version of this addon and am experiencing some issues with it. Here's my EmoticonMatch array:

$EmoticonMatch = array("[:0]" => "gasp.gif",);

It works sometimes, but if there's no space on both sides of the [:0], the emoticon isn't replaced with an image. So if you have something like:

Hey![:0]

or

h[:0]

It doesn't work.

Also, if there's a greater than / less than sign in the post prior to the emoticon, things get all screwey and the plugin appears to insert broken HTML. For example, if you make a post like this:

> [:0]

or...

blah blah blah >
blah blah
blah blah
blah
[:0]

Then broken HTML is inserted, unfortunately.

Would love to see both these things fixed, it's the only thing preventing me from upgrading to 2.0.18 on my main forum!

Shmizzle

@Tim @Todd @Lincoln has anything changed in 2.0.18 that might be causing the latter problem? FWIW my custom/old version of this plugin (which doesn't suffer from the first problem I mentioned) hooks into:

DiscussionController_BeforeCommentBody_Handler
PostController_BeforeCommentBody_Handler
PostController_BeforeDiscussionRender_Handler
PostController_BeforeCommentRender_Handler
PostController_BeforeDiscussionPreview_Handler

And in each of those callbacks a function is called which just does a str_replace on the text, replacing the emoticon code with img src HTML code. Again, works perfectly fine in 2.0.17 but for some reason it doesn't in 2.0.18.

oliverraduner

@Shmizzle I acknowledge issue #1 with the plugin, however for issue #2 I cannot reproduce it, even with 2.0.18.

Shmizzle

Thanks for the response. I wonder why that might be. You're using the same EmoticonMatch array I listed above, correct? FWIW when testing, I disabled all plugins except for this Emoticons plugin, including Htmlawed.