Feedback

SevMC

This discussion is related to the Noise addon.

Any Feedback?

peregrine

I think you have to change all the references to starting with line 64

src="/themes/Noise/design/images/...."

to src="themes/Noise/design/images/..."

it can't find the pngs otherwise for the css switcher.

in default.master.php

peregrine

nice theme. I'll learn something I'm sure by looking at its design

I think you may have to change all the references to starting with line 64 and also line 40 for the signout.

src="/themes/Noise/design/images/...."

to

src="themes/Noise/design/images/..."

it can't find the pngs otherwise for the css switcher.

in default.master.php

I'd also consider adding around line 531

#Head form input#Form_Search {
              background:white;
              color: black;
              }

peregrine

other/css/green.css:   background: url(http://makeitsound.org/themes/mis/design/images/bkg-green.png) fixed!important;
other/css/pink.css:   background: url(http://makeitsound.org/themes/mis/design/images/bkg-pink.png) fixed !important;
other/css/red.css:   background: url(http://makeitsound.org/themes/mis/design/images/bkg-red.png) fixed !important;
other/css/blue.css:   background: url(http://makeitsound.org/themes/mis/design/images/bkg-blue.png) fixed !important;

at least these there might be more.

thats why I suggested you look via grep -ri png *

422

I would strongly recommend NOT doing absolute URL's for your png images.

Its really a bad move. For masses of reasons.

Better is to add a 1px x 1px transparent png, into the theme template and use absolute url for that.

If you change your theme, or your server is down.. lots of peoples themes will eff up. Plus the amount of bandwidth and pings to your server will be ridiculous.

peregrine

an example.

background: url(../../design/images/bkg-blue.png)

then doublecheck all of your css files for references to your site to make sure you changed them all.

the theme also would be faster if you lose the @import url(http://fonts.googleapis.com/css?family=Lato:400,400italic,700,700italic); in custom.css.

delete all the references to Lato

and add the line to the body font-family:Arial,Tahoma,Calibri,Verdana,Geneva,sans-serif;

you also have two body statements for some reason.

peregrine

If you want the activities page to change colors for the comment link
you need to change this to your 5 color css files.

.MessageList .Meta a {

to this
.Activities .Meta a ,.MessageList .Meta a {

peregrine

I still think you need a change log for version changes. A user may not want to keep on re-installing each version - minute by minute for a padding change or a border color change. But they may want to if there is a serious bug. But it will certainly keep the theme at the top of the addons page and get more downloads :).

At some point, you will drive the users crazy with the minute by minute update. You might consider block changes on a less frequent interval unless you truly see the need. Just my thoughts.

422

Excellent. I was working on css switcher too. Nice design. With @peregrines help, i cant get it workin so will check your code out :)

SevMC

Thanks, I will :)

SevMC

Done, I changed the references and modified the search box. thanks :)

peregrine

@SevMC

I just noticed the pngs for theme switching do not show up at the bottom of the buttonbox for adding a comment, probably have to parse the url or scriptname and append the theme path or use document root and append the theme path in default.master.php - something like that. or it could be I'm seeing problems running on localhost.

Nice theme though.

SevMC

peregrine said: @SevMC

I just noticed the pngs for theme switching do not show up at the bottom of the buttonbox for adding a comment, probably have to parse the url or scriptname and append the theme path or use document root and append the theme path in default.master.php - something like that. or it could be I'm seeing problems running on localhost.

Nice theme though.

thanks :)

Yes, I think I will need to call the url in order to avoid reference problems.

SevMC

Fixed :)

GumCloud

Hi, I like it very much, but how come its like this on my site? [Link deleted by UnderDog]

As you can see, I'm not using the voting plugin, and the discussions list are nudged to the left and has a space on the right.

Its a very beautiful theme btw :)

SevMC

Well, you can change the background images to something more related ;)

You can find them here: YOURSITE/themes/Noise/design/images/(bkg.png, bkg-blue.png, bkg-green.png, etc...).

peregrine

I don't know if it was unintentional but you have some of the pngs pointing back to collect info of of your site. You could monitor who is using your theme that way :).

grep -ri png *

SevMC

haha not really :D, what pngs?

SevMC

Thanks :), it will help me see sites that are using the theme easily.

SevMC

New version! :D

1.0.5

peregrine

I'm started to wonder what your plan is:

you say haha not really :D, what pngs?

than you say New version! :D

without the changes - and it still goes back to your site.

I would never use a theme that calls back to the mothership for no reason other than to be tracked, but I don't have a forum so it doesn't matter to me. But for unsuspecting users of your theme it isn't a good idea for the reasons 422 mentions.

generally you might consider a changelog of what is different in each version.

well, I've tested enough here.

422

Your a star in my eyes @peregrine :)

SevMC

Hahah, don't worry I will fix the URL's as @442 suggest and untrack the pngs, the 1.0.5 version is the same as 1.0.4 but adding some images and modifying the credits.

SevMC

peregrine said: I'm started to wonder what your plan is:

How can I untrack them by the way?

SevMC

Thanks, I will fix them as soon as posible ;)

SevMC

422 said: I would strongly recommend NOT doing absolute URL's for your png images.

Its really a bad move. For masses of reasons.

Better is to add a 1px x 1px transparent png, into the theme template and use absolute url for that.

If you change your theme, or your server is down.. lots of peoples themes will eff up. Plus the amount of bandwidth and pings to your server will be ridiculous.

Oh, I thought that the png files had some kind of tracking system XD haha, not that they were directly linked to my site, I will change them for sure.

SevMC

peregrine said: an example.

background: url(../../design/images/bkg-blue.png)

then doublecheck all of your css files for references to your site to make sure you changed them all.

the theme also would be faster if you lose the @import url(http://fonts.googleapis.com/css?family=Lato:400,400italic,700,700italic); in custom.css.

delete all the references to Lato

and add the line to the body font-family:Arial,Tahoma,Calibri,Verdana,Geneva,sans-serif;

you also have two body statements for some reason.

Thak you very much for the help :)

SevMC

Everythig above is fixed in the new version: 1.0.6 :D

PS: All the comments with the "Accepted" Icon are the ones that had been taken for the theme's latest version (now 1.0.6).

peregrine

SevMC said: Everythig above is fixed in the new version: 1.0.6 :D

PS: All the comments with the "Accepted" Icon are the ones that had been taken for the theme's latest version (now 1.0.6).

:)

http://vanillaforums.org/discussion/comment/161765/#Comment_161765

SevMC

I made the latest versions because of the credits, first I just copied the credits that I had in my homepage that were related with the theme, but I noticed that some links were wrong, and some other credits were unecessary, so I thought it could be important because if one credit was wrong I could have problems with the author.

I don't think I will have any more critical updates because the theme is very simple, so I will upload a new version only if there is an important image change (like the background), or until a user reports something wrong with it.

So the users can be calm if another version comes out, because probably the changes will be just cosmetic (at least that I specifie that is something important).

Thanks for the suggestions @peregrine, I will make a changelog for the next versions :)

Laur

Credits, wrong position: http://i.imgur.com/AUEf6.png