Blog Documentation Try Vanilla Cloud
Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options

Horror in the code

TiGRTiGR ✭
edited November 2010 in Vanilla 2.0 - 2.8
Lincoln, why are you using 21 pcre calls for every post on page?! With 30 posts on page it takes 630 calls! This is a performance horror.

I've used less than 20 pcre calls for entire templating engine. Why this simple task should take that much of resources?
Tagged:

Comments

  • Options
    LincLinc Detroit Admin
    edited November 2010
    I lifted the entire AutoParagraph method straight from Wordpress. If you come up with a better solution than them, let me know.

    If you think automatically adding 'p' tags is simple, then I'd bet you haven't tried it.
  • Options
    judgejjudgej ✭
    Is there anything in the markdown code that can do this, since one of markdown's functions is to put paragraphs into the text (which it does nicely).
  • Options
    LincLinc Detroit Admin
    Unfortunately, I'm not familiar with the Markdown parsing.
  • Options
    SS ✭✭
    HtmlPurifier do it :p
  • Options
    judgejjudgej ✭
    edited November 2010
    The Markdown parser is there in the core, and is very handy and easy to use. It can be told what features to apply, so paragraph tags can be enabled on their own.

    How many regexs it runs, I don't know.
  • Options
    judgejjudgej ✭
    edited December 2010
    Just used the markdown processor myself (to display category descriptions in the discussions view) and it is incredibly simple to use. To convert a string to HTML using the markdown rules, the statement does the job:

    $html_string = Gdn_Format::To($markdown_string, 'markdown');

    That will put in paragraph marks, images, lists etc. That may be overkill just to handle paragraphs, but the markdown object can be instantiated by hand just to run specific parts of it.
  • Options
    mostmodernistmostmodernist
    It also doesn't add p tags to the first paragraph, only subsequent ones. just saying.
Sign In or Register to comment.