HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options
What is the best workflow to report bugfixes?
MikeBattaglia
New
in Feedback
I found a few pretty simple bugs tonight, all of which involve changing 1-2 lines of code in the Facebook plugin. I've supplied fixes for all of these bugs.
What is the right workflow to deal with this as it comes up? Do I post bugfixes here? Do I post them as issues in Github? Do I skip all of that and just make the hotfix into a PR? If so, do I make a separate PR for each one, or do I lump them all together?
Would be much appreciated; trying to get into a good workflow here!
0
Comments
See http://vanillaforums.org/discussion/27971/pull-requests-you
Yes, if you have a bugfix, ypu can opwn a PR on github for each one right away.
My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations
VanillaSkins.com - Plugins, Themes and Graphics for Vanillaforums OS
OK, thanks. And is a PR all I need to do? I shouldn't accompany that with a forum post, or an issue in the issue tracker, right?
And to confirm, you want a separate PR for each different bugfix, right?
@MikeBattaglia
Bleistivt isn't 'you', he's 'us'!
@MikeBattaglia Correct
@MikeBattaglia @Bleistivt Thanks for the great PRs this morning.