Awesome, I cannot wait until it's out of beta ;)

@flobster - Yep, that's fixed, too :)

@dejitaru - it searches both by default.

@dejitaru - I don't follow. The way Vanilla works is that it remembers the last comment you read in discussions, and then takes you to that one the next time you visit a discussion (so you can pick up where you left off).

When it comes to searching, it takes you to the comment you clicked on in the list of search results - wherever that may be in the discussion.

@dejitaru - I'm going to have to defer to @Todd on that (he wrote all of the search stuff), but I imagine it is using MySQL's fulltext relevance order.

Ahh ok makes sense thanks for the info.

Never-mind, it displays them to you when you do the upgrade.

I don't know what I'm doing wrong -- I installed a fresh copy off github master branch, search for a post I just made, and I get 0 results, no matter what keyword I try. The link given in the blog didn't work, it said no updates were necessary.

What should I look for in the SQL? Oh and when I search for nothing, I get an error message from PHP.

Oh duh. k, one sec. I searched for "write", a word in my discussion, and it said No results found but made the following SQL:

Gdn_SearchModel->Search('write', 0, 20)0.013198s
select *
from (
select match(d.Name) against('write') as `Relavence`, d.DiscussionID as `PrimaryID`, d.Name as `Title`, c.Body as `Summary`, concat('/discussion/', d.DiscussionID) as `Url`, d.DateInserted as `DateInserted`, d.InsertUserID as `UserID`, u.Name as `Name`
from GDN_Discussion d
join GDN_Comment c on d.FirstCommentID = c.CommentID
join GDN_User u on d.InsertUserID = u.UserID
where match(d.Name) against ('write')
union all
select match(c.Body) against('write') as `Relavence`, c.CommentID as `PrimaryID`, d.Name as `Title`, c.Body as `Summary`, concat('/discussion/comment/', c.CommentID, '/#Comment_', c.CommentID) as `Url`, c.DateInserted as `DateInserted`, c.InsertUserID as `InsertUserID`, u.Name as `Name`
from GDN_Comment c
join GDN_Discussion d on d.DiscussionID = c.DiscussionID
join GDN_User u on u.UserID = d.InsertUserID
where match(c.Body) against ('write')
) s
order by s.Relavence desc
limit 20;

I'm not sure why but when I execute the second statement in the union without

where match(c.Body) against ('write')

it does seem to work -- e.g. the following:

 select match(c.Body) against('write') as `Relavence`, c.CommentID as `PrimaryID`, d.Name as `Title`, c.Body as `Summary`, concat('/discussion/comment/', c.CommentID, '/#Comment_', c.CommentID) as `Url`, c.DateInserted as `DateInserted`, c.InsertUserID as `InsertUserID`, u.Name as `Name`
from GDN_Comment c
join GDN_Discussion d on d.DiscussionID = c.DiscussionID
join GDN_User u on u.UserID = d.InsertUserID

returns the 1 comment, with a relevance of 0. I figure perhaps then if the where statement, the relevance column, is 0, then that means exclude it rather than return it ... so with such a tiny dataset (one comment in one discussion), could that cause problems?

@Todd wrote the mysql fulltext implementation. Mentioning him here so he can add 2c.

Pushed the fix to github. Thanks guys.

The forum has just 5 posts, when I search for "Winter", it works, when I search for "write", it doesn't find that one post. I suspect maybe if only one result is found, it returns a relevance of 0, as in relevance should be ignored?

I'll turn on the debug mode right now, so you can see for yourself. [Edit: Crap, of course, debug mode won't let you run the SQL queries as I did above, but ... I'll try running them again then.]

Yeah. The relevance is kind of locked away in the logic of MySQL, but I think it works well on balance. I'm also guessing that MySQL's full text indexes might lag behind the data a tad as do with most of these type of searches.

I wonder if maybe, only for searches which return 0 results, we could swap to a non-relevance based search, perhaps instead a recency-sorted one for just that keyword. And then say "search term too common, results sorted by most recent". If such a generic search reveals nothing, then we know for sure that the word or terms were never used. Perhaps if this uses more CPU or something, it could be a checkbox-- or maybe there's some other trick people are using?

Lucene would be even better, but this is still one hell of an improvement over V1.

Perhaps the styling of the search results could be slightly different for discussion results (the entire thread) compared to comment results (a single post)?

Also, I don't know if this is relevant, but the addons/plugins search is currently very annoying, since I can search for a plugin by name and although it finds it, it is MILES down the pecking order. Just try it with something like "JQuery" for example :P Also, my preference of V1/V2, recent/popular is not remembered which is pretty annoying.